Revise API for position tracking#1413
Merged
Merged
Conversation
rocky
marked this pull request as draft
June 28, 2025 01:51
rocky
force-pushed
the
position-tracking
branch
2 times, most recently
from
June 28, 2025 10:09
d373842 to
94e9f4e
Compare
mmatera
reviewed
Jun 29, 2025
| for rule in rules: | ||
| result = rule.apply(self, evaluation, fully=True) | ||
| if result is not None and not result.sameQ(self): | ||
| if result.is_literal: |
rocky
added a commit
that referenced
this pull request
Jul 4, 2025
rocky
force-pushed
the
position-tracking
branch
5 times, most recently
from
July 6, 2025 15:53
675a80b to
9135c88
Compare
rocky
marked this pull request as ready for review
July 6, 2025 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start tracking locations in specific expressions to aid error reporting and debugging.
We need some care to make sure we don't bloat memory with positions. Right now, we start locations are tagged for FunctionApplyRule, an ExpressionPattern -> Python method. Here, the location is the Python method, or rather can be extracted from that. So we can reuse the location information that Python is storing anyway.
For Expressions and ExpressionPatterns that are read in from Files, things are more complicated..
This needs to be coordinated with a changes in mathics-scanner of the same branch name.